Proposal : type definition test cases #1414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2016
|
Rebased. |
|
@david-driscoll , would you able to share opinion this would works for you for type definition test? |
|
👍 Looks great, I need to get rid of that other PR and redo it some night. |
|
Cool, I'll check this in around today and it'll unblock your PR #1189. |
|
Merged with fffc586. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now test cases are migrated in typescript, it is possible to integrate type definition test into existing test case execution environment. This PR is initial proposal of logistics.
Changes are straightforward, test helper exports interface
typefor type definition assertion actually doesn't do anything but only serves as container of all type definition test. These will be verified via compile time of test cases.In test cases, very bottom of each test contains
typeassertion and list out possible type definition test cases, majorly<T>intentionwise this is same as #1189 does, only difference is logistics.
/cc @david-driscoll for visibility also.